Pub/Sub logging hygiene. #4471
Merged
Pub/Sub logging hygiene. #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
added
api: pubsub
googlebot
added
the
cla: yes
dhermes
commented
Nov 28, 2017
| @@ -167,7 +191,7 @@ def on_response(self, response): | |||
| For each message, schedule a callback with the executor. | |||
| """ | |||
| for msg in response.received_messages: | |||
| _LOGGER.debug('New message received from Pub/Sub: %r', msg) | |||
| _LOGGER.debug('New message received from Pub/Sub:\n%r', msg) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Nov 28, 2017
Uses newline character when logging protobufs that may end up having
newlines in them. These are harder to grok in the log output since
it "blends" the protobuf and the description. For example.
Received response: received_messages {
ack_id: "Pn41MEV..."
message {
data: ...
vs.
Received response:
received_messages {
ack_id: "Pn41MEV..."
message {
data: ...
Also
- replaced a lambda with a simple function
- added docstrings to two default callbacks used by the
`policy.thread.Policy` implementation.
- updated grammatical error in a comment
- replaced a bare `if future` with `if future is not None`
dhermes
force-pushed
the
pubsub-logging-hygiene
branch
from
70811e3
to
ff558ad
Compare
|
Changed 3 instances of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses newline character when logging protobufs that may end up having newlines in them. These are harder to grok in the log output since it "blends" the protobuf and the description. For example.
vs.
Also
lambdawith a simple functionpolicy.thread.Policyimplementation.if futurewithif future is not NoneContext: I have discovered each of these "issues" while dealing with #4463 and #4234.