Updating AppVeyor configuration. #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
appveyor-revamp
branch
from
b505ce9 to
724ed27
Compare
In particular: - Removing `install.ps1` (all the needed Python versions are already there) - Removing `run_with_env.cmd` (and usage of it) since our code is pure Python and all of our dependencies have Windows wheels - Dropping distinction between PYTHON_VERSION and PYTHON_MAJMIN_VERSION, since AppVeyor will update anyhow - Programmatically computing PYTHON_(ARCH|VERSION) - Adding a more comprehensive `env_info.py` instead of using `python -c` - Removing `after_test` section that built MSI / WinInst and corresponding `artifacts` section that upload them - Removing `build_script` section that just runs `setup.py build` (it's irrelevant since we are pure Python) - Using the absolute path to `nox.exe` rather than hacking by deleting `%APPVEYOR_BUILD_FOLDER%/nox.py`
dhermes
force-pushed
the
appveyor-revamp
branch
from
724ed27 to
9cd204c
Compare
theacodes
approved these changes
Nov 1, 2017
This was referenced Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
install.ps1(all the needed Python versions are already there)run_with_env.cmd(and usage of it) since our code is pure Python and all of our dependencies have Windows wheelsPYTHON_VERSIONandPYTHON_MAJMIN_VERSION, since AppVeyor will update anyhowPYTHON_(ARCH|VERSION)env_info.pyinstead of usingpython -cafter_testsection that built MSI / WinInst and correspondingartifactssection that upload thembuild_scriptsection that just runssetup.py build(it's irrelevant since we are pure Python)nox.exerather than hacking by deleting%APPVEYOR_BUILD_FOLDER%/nox.py