Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify 'user_project' semantics for API wrapper methods. #4199

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Clarify 'user_project' semantics for API wrapper methods. #4199

merged 1 commit into from
Oct 16, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 16, 2017

Closes #4142.

[ci skip]

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. docs labels Oct 16, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2017
dhermes
dhermes approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I assume user_project is a valid attr on all of the classes with annotated methods?)

@tseaver
Copy link
Contributor Author

tseaver commented Oct 16, 2017

Yes, it is defined on the bucket: blob and notification instances have read-only properties which "borrow" it from the bucket.

@tseaver tseaver merged commit 7edad2d into googleapis:master Oct 16, 2017
@tseaver tseaver deleted the 4142-storage-user_project-docstrings branch October 16, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot