Skip user_project-based rewrite tests if envvar is not set.#4175
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Oct 12, 2017
tseaver:storage-systest-skip-rewrite-user_project
Merged
Skip user_project-based rewrite tests if envvar is not set.#4175tseaver merged 1 commit intogoogleapis:masterfrom tseaver:storage-systest-skip-rewrite-user_project
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:storage-systest-skip-rewrite-user_project
Conversation
googlebot
added
the
cla: yes
dhermes
approved these changes
Oct 12, 2017
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM (very tough to review this!)
Contributor
Author
Neither of those tests is sensible if the environment variable is not set. |
Contributor
|
(sarcasm) |
Contributor
Author
|
(tone deaf) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.