Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 21, 2017

Supersedes #3930.

Closes #3775.

/cc vkedia

@tseaver tseaver added api: spanner Issues related to the Spanner API. release blocking Required feature/issue must be fixed prior to next release. labels Sep 21, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Sep 21, 2017

@vkedia, @bjwatson PTAL

@lukesneeringer
Copy link
Contributor

After @vkedia says yes, I will start the process for a Spanner release.

@bjwatson
Copy link

Thanks @lukesneeringer, @tseaver, and @jonparrott!

LAST = (
self._make_item(3),
)
ITEMS = FIRST + SECOND + LAST

This comment was marked as spam.

This comment was marked as spam.

self.assertEqual(list(resumable), list(ITEMS))
restart.assert_called_once_with()

def test_iteration_w_raw_raising_unavailable(self):

This comment was marked as spam.

This comment was marked as spam.

@lukesneeringer
Copy link
Contributor

Is this approved, @vkedia?

@tseaver tseaver merged commit 5a0fe35 into master Sep 21, 2017
@tseaver tseaver deleted the 3775-spanner-retry-streaming-exceptions-bullwinkle branch September 21, 2017 22:30
This was referenced Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants