BigQuery: Remove dataset property from TableReference and add project/dataset_id properties #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Sep 20, 2017
tswast
pushed a commit
that referenced
this pull request
Sep 25, 2017
…/dataset_id properties (#4011) * adds dataset_id and project properties to TableReference * Remove dataset property from Table and TableReference
tswast
pushed a commit
that referenced
this pull request
Oct 12, 2017
…/dataset_id properties (#4011) * adds dataset_id and project properties to TableReference * Remove dataset property from Table and TableReference
tswast
pushed a commit
that referenced
this pull request
Oct 16, 2017
…/dataset_id properties (#4011) * adds dataset_id and project properties to TableReference * Remove dataset property from Table and TableReference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataset property (of type DatasetReference) in the TableReference class was primarily being used for the dataset_id and project properties. This change replaces the dataset property with dataset_id and project properties to make TableReference consistent with the Table class.