Allowing dict (as an Entity) for property values.#3927
Merged
dhermes merged 2 commits intogoogleapis:masterfrom Sep 8, 2017
Merged
Allowing dict (as an Entity) for property values.#3927dhermes merged 2 commits intogoogleapis:masterfrom
dict (as an Entity) for property values.#3927dhermes merged 2 commits intogoogleapis:masterfrom
Conversation
dhermes
added
api: datastore
googlebot
added
the
cla: yes
Contributor
Author
|
Man, Python 2 I am ready for you to disappear: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3177 |
tseaver
approved these changes
Sep 7, 2017
Contributor
Author
|
@tseaver thanks for the review. @lukesneeringer Can you also take a look? I'm a bit worried I've over-simplified this fix. |
lukesneeringer
approved these changes
Sep 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3923.