Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unsigned credentials error DRY. #3794

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Make unsigned credentials error DRY. #3794

merged 2 commits into from
Aug 11, 2017

Conversation

lukesneeringer
Copy link
Contributor

Fixes #3031.

@lukesneeringer lukesneeringer self-assigned this Aug 11, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2017
dhermes
dhermes approved these changes Aug 11, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so very DRY @lukesneeringer

@theacodes
Copy link
Contributor

Thanks for doing this, @lukesneeringer

@lukesneeringer lukesneeringer merged commit c33e9d4 into googleapis:master Aug 11, 2017
@lukesneeringer
Copy link
Contributor Author

Fix-it week! :-D

@lukesneeringer lukesneeringer deleted the issue-3031 branch August 11, 2017 19:56
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer @landrito
Make unsigned credentials error DRY. (googleapis#3794)
2557084
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Make unsigned credentials error DRY. (googleapis#3794)
00e4887
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Make unsigned credentials error DRY. (googleapis#3794)
cbbac6e
@lukesneeringer lukesneeringer mentioned this pull request Aug 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@theacodes theacodes theacodes approved these changes

Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @theacodes @dhermes @googlebot