Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google.api.core.exceptions #3738

Merged
merged 6 commits into from
Aug 8, 2017
Merged

Add google.api.core.exceptions #3738

merged 6 commits into from
Aug 8, 2017

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2017
dhermes
dhermes reviewed Aug 7, 2017
View reviewed changes
core/google/api/core/exceptions.py
@@ -0,0 +1,399 @@
# Copyright 2014 Google Inc.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py Outdated
# See the License for the specific language governing permissions and
# limitations under the License.

"""Exceptions raised by Google API core & clients."""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py

class GoogleAPIError(Exception):
"""Base class for all exceptions raised by Google API Clients."""
pass

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py


class _GoogleAPICallErrorMeta(type):
"""Metaclass for registering GoogleAPICallError subclasses."""

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py Outdated
"""Base class for exceptions raised by calling API methods."""

code = None
"""int: The HTTP status code associated with this error.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py
except ValueError:
payload = {'error': {'message': response.text or 'unknown error'}}

error_message = payload.get('error', {}).get('message', 'unknown error')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py Outdated

exception = from_http_status(
response.status_code, message, errors=errors)
exception.response = response

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py Outdated

if error.grpc_status_code is None:
error.grpc_status_code = status_code

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py
GoogleAPICallError: An instance of the appropriate subclass of
:class:`GoogleAPICallError`.
"""
if isinstance(rpc_exc, grpc.Call):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/tests/unit/api_core/test_exceptions.py
@@ -0,0 +1,159 @@
# Copyright 2014 Google Inc.

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Aug 7, 2017

Tests fail due to overage gap.

@lukesneeringer lukesneeringer mentioned this pull request Aug 7, 2017
Closed
@theacodes
Copy link
Contributor Author

I think I addressed all comments. Test coverage also fixed, thanks @tseaver.

This was referenced Aug 7, 2017
Closed
Merged
@lukesneeringer lukesneeringer mentioned this pull request Aug 8, 2017
Closed
dhermes
dhermes reviewed Aug 8, 2017
View reviewed changes
core/google/api/core/exceptions.py Outdated

@property
def response(self):
"""Optional[Union[requests.Request, grpc.Call]]L The response or

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/api/core/exceptions.py
GoogleAPICallError: An instance of the appropriate subclass of
:class:`GoogleAPICallError`.
"""
if isinstance(rpc_exc, grpc.Call):

This comment was marked as spam.

Sign in to view

@theacodes
Copy link
Contributor Author

@dhermes @lukesneeringer are we good to merge? (pending CI)?

@dhermes
Copy link
Contributor

dhermes commented Aug 8, 2017

LGTM

@theacodes theacodes merged commit abfec70 into googleapis:master Aug 8, 2017
@theacodes
Copy link
Contributor Author

Thanks all ✨ this is the first step to a unified core. :)

@theacodes theacodes deleted the api-core-exceptions branch August 8, 2017 17:32
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@landrito
Add google.api.core.exceptions (googleapis#3738)
897eed2 
* Add google.api.core.exceptions

* Add google.api.core to coverage report

* Alias google.cloud.exceptions to google.api.core.exceptions

* Fix lint

* Address review comments

* Fix typo
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Add google.api.core.exceptions (googleapis#3738)
b124ca8 
* Add google.api.core.exceptions

* Add google.api.core to coverage report

* Alias google.cloud.exceptions to google.api.core.exceptions

* Fix lint

* Address review comments

* Fix typo
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Add google.api.core.exceptions (googleapis#3738)
555b91c 
* Add google.api.core.exceptions

* Add google.api.core to coverage report

* Alias google.cloud.exceptions to google.api.core.exceptions

* Fix lint

* Address review comments

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theacodes @tseaver @dhermes @lukesneeringer @googlebot