Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systest for round-trip of NULL INT64. #3665

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Add systest for round-trip of NULL INT64. #3665

merged 1 commit into from
Jul 25, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 24, 2017

Include NULL values in ARRAY<INT64>.

@tseaver
Add systest for round-trip of NULL INT64.
7998b5a 
Include NULL values in ARRAY<INT64>.
@tseaver tseaver added api: spanner Issues related to the Spanner API. testing labels Jul 24, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Jul 25, 2017

These changes are trivial, they pass for me, and logging is screwing us again.

@tseaver tseaver merged commit dd372df into master Jul 25, 2017
@tseaver tseaver deleted the spanner-systest-int64-null-array-roundtrip branch July 25, 2017 00:44
@dhermes
Copy link
Contributor

dhermes commented Jul 25, 2017

LGTM post-hoc

@tseaver
Copy link
Contributor Author

tseaver commented Jul 25, 2017

@dhermes Thanks! Monorepoque delenda est!

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tseaver @landrito
Add systest for round-trip of NULL INT64. (googleapis#3665)
7c4d00a 
Include NULL values in ARRAY<INT64>.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Add systest for round-trip of NULL INT64. (googleapis#3665)
df304c0 
Include NULL values in ARRAY<INT64>.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Add systest for round-trip of NULL INT64. (googleapis#3665)
2482209 
Include NULL values in ARRAY<INT64>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot