Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech GAPIC to master #3607

Merged
merged 9 commits into from
Jul 14, 2017
Merged

Speech GAPIC to master #3607

merged 9 commits into from
Jul 14, 2017

Conversation

lukesneeringer
Copy link
Contributor

This is #3483, but using master as the base.
The previous PR only included manual code to ease review.

@lukesneeringer lukesneeringer self-assigned this Jul 14, 2017
@lukesneeringer lukesneeringer requested a review from dhermes July 14, 2017 18:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2017
@lukesneeringer
Copy link
Contributor Author

@dhermes Would you please look over setup.py and speech/setup.py? (Merge conflicts.)

dhermes
dhermes reviewed Jul 14, 2017
View reviewed changes
docs/speech/index.rst Outdated
means to configure your application. Each instance holds
an authenticated connection to the Cloud Speech Service.

For an overview of authentication in ``google-cloud-python``, see
:doc:`/core/auth`.

Assuming your environment is set up as described in that document,
create an instance of :class:`~google.cloud.speech.client.Client`.
create an instance of :class:`~.google.cloud.speech.SpeechClient`.

This comment was marked as spam.

Sign in to view

docs/speech/index.rst Outdated
... speech_contexts=hints,
>>> from google.cloud import speech
>>> client = speech.SpeechClient()
>>> result = client.recognize(

This comment was marked as spam.

Sign in to view

docs/speech/index.rst Outdated
... max_alternatives=1,
... profanity_filter=True,
>>> client = speech.SpeechClient()
>>> result = client.recognize(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

nox.py Outdated
@@ -30,13 +30,13 @@ def docs(session):
# Install Sphinx and also all of the google-cloud-* packages.
session.chdir(os.path.realpath(os.path.dirname(__file__)))
session.install('Sphinx >= 1.6.2', 'sphinx_rtd_theme')
session.install('-e', '.')

This comment was marked as spam.

Sign in to view

speech/google/cloud/gapic/speech/v1/enums.py
@@ -0,0 +1,86 @@
# Copyright 2016 Google Inc. All rights reserved.

This comment was marked as spam.

Sign in to view

speech/tests/unit/test__gax.py Outdated
return_value=mock.sentinel.stub)
def test_constructor(self, mocked_stub, mocked_cls, mocked_channel):
def test_constructor(self, mocked_stub, mocked_init, mocked_channel):

This comment was marked as spam.

Sign in to view

speech/tests/unit/test__gax.py
channel=mock.sentinel.channel, lib_name='gccl',
lib_version=__version__)
mocked_channel.assert_called_once_with(
mock_cnxn.credentials, DEFAULT_USER_AGENT,
mocked_cls.SERVICE_ADDRESS)
'speech.googleapis.com')

This comment was marked as spam.

Sign in to view

speech/tests/unit/test_helpers.py Outdated
from google.auth.credentials import Credentials

from google.cloud.speech_v1 import SpeechClient
from google.cloud.speech_v1 import types

This comment was marked as spam.

Sign in to view

speech/tests/unit/test_helpers.py Outdated
from google.cloud.speech_v1 import types


class HelperTests(unittest.TestCase):

This comment was marked as spam.

Sign in to view

speech/tests/unit/test_helpers.py Outdated


class HelperTests(unittest.TestCase):
def setUp(self):

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 14, 2017
@dhermes dhermes merged commit 401bf40 into master Jul 14, 2017
@dhermes dhermes deleted the speech-gapic-vendor branch July 14, 2017 21:22
@dhermes
Copy link
Contributor

dhermes commented Jul 14, 2017 

$ git log speech-0.26.0..speech-0.27.0 --pretty=%H -- speech/
401bf4018ae8eaf4fabc77e4aac30564e9289aab
da3a7bbe8c7770540c2149fabfc6f74db89f7ce4
bc7b0fdb9fd99b2c86de9830a25cfaaa295b1c45
2a4511ca8a9a4b0569c583a7c4ca6ba0aaf06545
b9cb6d17236528ddce982c3e802af3221de80880
39feb3e23d451963ca31b383d8b395afcf7ab817
6ab3e0127a1edf8b1f9f1603f3c1342473563ea7

These correspond to

@dhermes dhermes mentioned this pull request Jul 27, 2017
Closed
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer @landrito
Speech GAPIC to master (googleapis#3607)
86ba896 
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (googleapis#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Speech GAPIC to master (googleapis#3607)
0ef29da 
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (googleapis#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Speech GAPIC to master (googleapis#3607)
17db537 
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (googleapis#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
atulep pushed a commit that referenced this pull request Apr 3, 2023
@lukesneeringer @dhermes
Speech GAPIC to master (#3607)
c377f7e 
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@lukesneeringer @dhermes
Speech GAPIC to master (#3607)
d90c659 
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@lukesneeringer @dhermes
Speech GAPIC to master (#3607)
3744103 
* Vendor the GAPIC for Speech.

* Speech Partial Veneer (#3483)

* Update to docs based on @dhermes catch.

* Fix incorrect variable.

* Fix the docs.

* Style fixes to unit tests.

* More PR review from me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duggelz duggelz duggelz left review comments

@dhermes dhermes dhermes left review comments

@theacodes theacodes theacodes left review comments

Assignees

@lukesneeringer lukesneeringer

Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukesneeringer @googlebot @dhermes @theacodes @duggelz