Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep runtimeconfig-0.25.0 release. #3545

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Prep runtimeconfig-0.25.0 release. #3545

merged 1 commit into from
Jun 26, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 26, 2017

Requires merge of #3526 to bump core to 0.25.0.

Draft release notes:

google-cloud-runtimeconfig-0.25.0

  • Update google-cloud-core dependency to ~= 0.25.

Excluded from notes:

@tseaver tseaver added api: runtimeconfig Issues related to the Cloud Runtime Config API API. packaging labels Jun 26, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2017
@dhermes
Copy link
Contributor

dhermes commented Jun 26, 2017

@tseaver I'm not sure about the use of ~ (I presume to mean approximately?) How about instead:

Update google-cloud-core dependency to 0.25.x series?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2017

I meant to be using ~=, in the PEP 440 sense.

@dhermes
Copy link
Contributor

dhermes commented Jun 26, 2017

I'm not sure many people know ~= in the PEP 440 sense. I've read PEP 440 and I don't.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2017

AFAIK, it is what we should be using rather than the incantation we are now.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2017

$ /opt/Python-2.7.13/bin/virtualenv /tmp/pep440
New python executable in /tmp/pep440/bin/python
Installing setuptools, pip, wheel...done.
$ /tmp/pep440/bin/pip install google-cloud-core~=0.24
Collecting google-cloud-core~=0.24
  Using cached google_cloud_core-0.24.1-py2.py3-none-any.whl
...

Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhermes
Copy link
Contributor

dhermes commented Jun 26, 2017

I'm not sure we're using it anywhere? Or do you mean rather than the lower-upper bound combination?

@tseaver tseaver merged commit 0ac5a24 into googleapis:master Jun 26, 2017
@tseaver tseaver deleted the runtimeconfig-0.25.0-prep branch June 26, 2017 22:51
tseaver added a commit that referenced this pull request Jul 10, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: runtimeconfig Issues related to the Cloud Runtime Config API API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants