Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new encodings. #3292

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Conversation

lukesneeringer
Copy link
Contributor

Fixes #3288.

@lukesneeringer lukesneeringer requested a review from dhermes April 12, 2017 14:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though this is a band-aid fix. We shouldn't be hardcoding something that can be retrieved from the .proto generated files (pb2 and other GAPIC)

@lukesneeringer lukesneeringer merged commit 19e5608 into googleapis:master Apr 12, 2017
@lukesneeringer
Copy link
Contributor Author

Concur, but not my problem at the moment.

@lukesneeringer lukesneeringer deleted the issue-3288 branch April 12, 2017 20:33
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
atulep pushed a commit that referenced this pull request Apr 3, 2023
atulep pushed a commit that referenced this pull request Apr 18, 2023
parthea pushed a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants