Return int from 'total_rows'/'total_bytes_processed', if present. #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: bigquery
googlebot
added
the
cla: yes
|
Crap, that was the wrong PR. Can I get a post-facto review, or should I revert? |
dhermes
reviewed
Feb 13, 2017
| query = self._make_one(self.QUERY, client) | ||
| self.assertIsNone(query.name) | ||
|
|
||
| def test_name_broken_job_reference(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…ows_integer Return int from 'total_rows'/'total_bytes_processed', if present. Merging without waiting for the speech fix to land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds explicit unit test coverage for the scalar properties of
Query(previously covered implicitly via tests of other methods).The second commit adds the convert-to-int logic, because the back-end is marshalling integers as JSON-be-damned strings.
Closes #3004.