Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create exceptions (and bases) for RPC-only errors in core #2936

Closed
wants to merge 3 commits into from
Closed

Create exceptions (and bases) for RPC-only errors in core #2936

wants to merge 3 commits into from

Commits on Jan 17, 2017

  1. Create exceptions (and bases) for RPC-only errors 

    Several RPC exceptions that can be raised from a protobuf response map
to the same HTTP status code, which creates some semantic overlap, as
the current strategy is to always map to an HTTP status code. An example
of this is DATA_LOSS and INTERNAL, which are two different conditions as
reported by the backend but are mapped to HTTP 500 (as per the comments
in the proto definition), but may have different operational semantics.
    Ben Demaree committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    2481cdc View commit details
    Browse the repository at this point in the history

  2. Add missing code

    Ben Demaree committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    2ea002e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2017

  1. Tweak spacing in test case

    Ben Demaree committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    15192a0 View commit details
    Browse the repository at this point in the history