Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force close logging handler. #2851

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Force close logging handler. #2851

merged 1 commit into from
Dec 12, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 10, 2016

Allow tempdir cleanup to work as expected on Windows.

Allow tempdir cleanup to work as expected on Windows.
@tseaver tseaver added api: logging Issues related to the Cloud Logging API. testing labels Dec 10, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2016
@tseaver tseaver merged commit e0ccd73 into googleapis:master Dec 12, 2016
@tseaver tseaver deleted the plug-tempdir-leak-windows branch December 12, 2016 13:54
@dhermes
Copy link
Contributor

dhermes commented Dec 12, 2016

Something very wrong with Python 3:

Happened after this merged, but I don't think it was caused by this PR

@daspecster
Copy link
Contributor

@dhermes yeah I've been looking into this but I haven't found the cause other than what's in the trace.

Let's chat about it here #2856.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants