Add system tests for detect_faces(). #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
changed the title
tseaver
suggested changes
Dec 6, 2016
| landmark.landmark_type, False) | ||
| if valid_landmark_type: | ||
| return True | ||
| return False |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| self._assert_likelihood(face.headwear) | ||
| self.assertGreater(abs(face.angles.roll), 0.0) | ||
| self.assertGreater(abs(face.angles.pan), 0.0) | ||
| self.assertGreater(abs(face.angles.tilt), 0.0) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| def _assert_coordinate(self, coordinate): | ||
| if coordinate is None: | ||
| return True |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
reviewed
Dec 6, 2016
| if coordinate is None: | ||
| return True | ||
|
|
||
| self.assertIn(type(coordinate), [int, float]) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
reviewed
Dec 6, 2016
| return True | ||
|
|
||
| self.assertIn(type(coordinate), [int, float]) | ||
| return |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Dec 6, 2016
|
Travis is green, merging. |
10 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…-tests Add system tests for detect_faces().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2753
This adds system test for
detect_faces().test_detect_faces_content (vision.TestVisionClientFace) ... ok test_detect_faces_filename (vision.TestVisionClientFace) ... ok test_detect_faces_gcs (vision.TestVisionClientFace) ... ok test_detect_logos_content (vision.TestVisionClientLogo) ... ok test_detect_logos_filename (vision.TestVisionClientLogo) ... ok test_detect_logos_gcs (vision.TestVisionClientLogo) ... ok ---------------------------------------------------------------------- Ran 6 tests in 9.324s OK ________________________________________________________ summary ________________________________________________________ system-tests: commands succeeded congratulations :)