Add system test for Vision Logo detection. #2788
Conversation
googlebot
added
the
cla: yes
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
Mostly LG but a few changes are "needed"
| TEST_MODULES = { | ||
| 'datastore': datastore, | ||
| 'speech': speech, | ||
| 'vision': vision, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
system_tests/vision.py
Outdated
| CLIENT = None | ||
| TEST_BUCKET = None | ||
|
|
||
| LOGO_FILE = os.path.join(os.path.dirname(__file__), 'data', 'logo.png') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
system_tests/vision.py
Outdated
| bucket_retry(Config.TEST_BUCKET.delete)(force=True) | ||
|
|
||
|
|
||
| class TestSpeechClient(unittest.TestCase): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| value.delete() | ||
|
|
||
| def _assert_logo(self, logo): | ||
| self.assertEqual(logo.description, 'Google') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
daspecster
force-pushed
the
vision-add-system-tests
branch
from
bd0270b to
c6019d8
Compare
|
I added the filename test as well. system-tests runtests: commands[1] | python /Users/daspecster/Documents/google/google-cloud-python/system_tests/attempt_system_tests.py vision
test_detect_logos_content (vision.TestVisionClient) ... ok
test_detect_logos_filename (vision.TestVisionClient) ... ok
test_detect_logos_gcs (vision.TestVisionClient) ... ok
----------------------------------------------------------------------
Ran 3 tests in 5.540s
OK
____________________________________________________ summary _____________________________________________________
system-tests: commands succeeded
congratulations :) |
daspecster
force-pushed
the
vision-add-system-tests
branch
from
c6019d8 to
e6ea013
Compare
|
Squashed! And cancelled travis #SaveCycles. |
…tests Add system test for Vision Logo detection.
4 participants
Towards: #2753 and #2526.
I will add the filename test after #2778 is merged.
To get this kicked off though, here are some system tests for
detect_logo().