Fix #170: handle namespaces in queries #255

tseaver · 2014-10-17T15:25:54Z

Review this PR after #254 is merged (it is based from that branch).

Fixes #170.

coveralls · 2014-10-17T15:32:54Z

Coverage remained the same when pulling 3b582a7 on tseaver:170-query_namespaces into 906700b on GoogleCloudPlatform:master.

tseaver · 2014-10-17T20:15:10Z

Merged from the trunk: the earlier changesets (from PR #253) are now gone from the diff.

coveralls · 2014-10-17T20:21:28Z

Coverage remained the same when pulling 8a4ee61 on tseaver:170-query_namespaces into 83e8262 on GoogleCloudPlatform:master.

tseaver · 2014-10-17T21:54:13Z

Now rebased for your viewing pleasure.

coveralls · 2014-10-17T22:03:50Z

Coverage remained the same when pulling 7820d91 on tseaver:170-query_namespaces into 83e8262 on GoogleCloudPlatform:master.

gcloud/datastore/query.py

dhermes · 2014-10-19T17:38:09Z

It seems namespace would occur in more places. Did you systematically go through methods with grep or something? In other words, do we have some way of knowing this is comprehensive?

tseaver · 2014-10-19T21:03:11Z

I looked at all the places that 'namespace' appeared in the protobuf spec, and verified that we were handling all of them:

'namespace' is a field in the PartitionId struct
That struct occurs only as a field of Key objects and a field of RunQueryRequest

We are handling those cases with this change.

Rather than those for testcase's '_makeOne'.

Fixes #170.

tseaver · 2014-10-19T21:08:07Z

I have rebased to fix the merge conflicts.

coveralls · 2014-10-19T21:16:55Z

Coverage remained the same when pulling bfffdbf on tseaver:170-query_namespaces into 86b308a on GoogleCloudPlatform:master.

dhermes · 2014-10-19T22:41:36Z

From viewing the discovery doc it seems the namespace can be included in the key as well.

Otherwise LGTM

tseaver · 2014-10-19T23:30:24Z

Right, but we already allow for passing the namespace to the Key ctor, setting / geting it through a 'namespace' method, and copying it to / from the PartitionId protobuf element. It was only the 'run_query' bits which lacked support until this PR.

Fix #170: handle namespaces in queries

chore: relocate owl bot post processor

* chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add `available_cpu ` field feat: add `kms_key_name` field to ServiceConfig (the CMEK use case) feat: add `max_instance_request_concurrency` field feat: add `security_level` field PiperOrigin-RevId: 516979219 Source-Link: googleapis/googleapis@650f7cd Source-Link: googleapis/googleapis-gen@3c4d23f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2M0ZDIzZmQ3NjZlZGRiMmM3MjZiNDBkMjNlZjAxMjk3NGEzMjUxZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.11.7 PiperOrigin-RevId: 573230664 Source-Link: googleapis/googleapis@93beed3 Source-Link: googleapis/googleapis-gen@f4a4eda Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.8 PiperOrigin-RevId: 574178735 Source-Link: googleapis/googleapis@7307199 Source-Link: googleapis/googleapis-gen@ce3af21 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

These two lines bring the rules on this repo in line with the defaults: https://github.com/googleapis/repo-automation-bots/blob/63c858e539e1f4d9bb8ea66e12f9c0a0de5fef55/packages/sync-repo-settings/src/required-checks.json#L40-L50

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* chore: allow releases on previous majors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

@busunkim96

- [ ] Regenerate this pull request now. fix: add 'dict' annotation type to 'request' Committer: @busunkim96 PiperOrigin-RevId: 398509016 Source-Link: googleapis/googleapis@b224dfa Source-Link: googleapis/googleapis-gen@63a1db7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update post processor image * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix typo * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Also, avoid using default environment credentials in unit tests

chore: relocate owl bot post processor

…[autoapprove] (#255) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

Source-Link: googleapis/synthtool@3551acd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:230f7fe8a0d2ed81a519cfc15c6bb11c5b46b9fb449b8b1219b3771bcb520ad2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* BUG: avoid load jobs for empty dataframes No reason to run a load job if there is no data to load. This avoids a "Empty schema specified for the load job." error when the DataFrame also contains no columns. * Blacken * Remove unused test_size variable.

…ignment (#255) This is necessary for maintaining field integrity during round trip conversions to python dicts. E.g. class MyMessage(proto.Message): data = proto.Field(proto.BYTES, number=1) my_message = MyMessage(data=b"this is a data payload") assert my_message == MyMessage(MyMessage.to_dict(my_message)) Conversion to and from json does not exhibit this problem because the entire ser/des logic is encapuslated by the vanilla protobuf runtime, which handles this problem. Fix for #249

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@febaccc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:caffe0a9277daeccc4d1de5c9b55ebba0901b57c2f713ec9c876b0d4ec064f61 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * Update requirements-test.txt --------- Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>

) Source-Link: googleapis/synthtool@7804ade Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

#255) http://blog.pytest.org/2016/whats-new-in-pytest-30/ https://twitter.com/hashtag/dropthedot

tseaver mentioned this pull request Oct 17, 2014

Add support for namespaces #1

Closed

dhermes reviewed Oct 19, 2014
View reviewed changes

gcloud/datastore/query.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 4 commits October 19, 2014 17:03

Test *real* ctor defaults.

6a732f1

Rather than those for testcase's '_makeOne'.

Add namespace to query ctor / clone.

b7bee41

Typos.

c120f65

Pass namespace when fetching results.

bfffdbf

Fixes #170.

tseaver added a commit that referenced this pull request Oct 19, 2014

Merge pull request #255 from tseaver/170-query_namespaces

67b8302

Fix #170: handle namespaces in queries

tseaver merged commit 67b8302 into googleapis:master Oct 19, 2014

tseaver deleted the 170-query_namespaces branch October 19, 2014 23:31

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore: relocate owl bot post processor (#255)

b0ad55d

chore: relocate owl bot post processor

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: relocate owl bot post processor (#255)

2cc0a82

chore: relocate owl bot post processor

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: relocate owl bot post processor (#255)

194b45b

chore: relocate owl bot post processor

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore: relocate owl bot post processor (#255)

e61007d

chore: relocate owl bot post processor

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-api-core to v2.10.2 (#255)

5c0e0d1

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.10.0 (#255)

6f73848

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-monitoring to v2.8.0 (#255)

a7f242d

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pillow to v8.4.0 (#255)

c887148

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: drop six (#255)

339af1d

Also, avoid using default environment credentials in unit tests

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: allow releases from previous major versions (#255)

659e91e

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: relocate owl bot post processor (#255)

8363384

chore: relocate owl bot post processor

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(deps): update dependency pyarrow to v5 (#255)

1076b3a

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(deps): update dependency pyarrow to v5 (#255)

3d2a192

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: release 1.1.0 (#255)

47a1ab7

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: strip unnecessary 'type: ignore' comments (#255)

1e8b669

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update all dependencies (#255)

5ff48b3

* chore(deps): update all dependencies * Update requirements-test.txt --------- Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: release 2.0.1 (#255)

534c95a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency google-cloud-storage to v1.37.1 (#255)

5d0d288

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency google-cloud-storage to v1.37.1 (#255)

b4e043c

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(deps): update dependency google-cloud-storage to v1.37.1 (#255)

ba02109

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(deps): update dependency google-cloud-storage to v1.37.1 (#255)

5e89f49

parthea pushed a commit that referenced this pull request Nov 26, 2025

Use pytest instead of py.test per upstream recommendation, #dropthedot (

96db48c

#255) http://blog.pytest.org/2016/whats-new-in-pytest-30/ https://twitter.com/hashtag/dropthedot

Fix #170: handle namespaces in queries #255

Fix #170: handle namespaces in queries #255

Uh oh!

Conversation

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

coveralls commented Oct 19, 2014

Uh oh!

dhermes commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants