'Config.IN_EMULATOR' is a boolean. #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Five tests were being skipped due to false positves (testing 'if Config.IN_EMULATOR is not None:' vs. 'if Config.IN_EMULATOR:'.
googlebot
added
the
cla: yes
|
DERP! Sorry @tseaver. Should've been a boolean all along. My bad on not being careful with my find and replace LGTM |
tseaver
deleted the
system_tests-bigtable-false_positive_emulator_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Five tests were being skipped due to false positves (testing
if Config.IN_EMULATOR is not None:vs.if Config.IN_EMULATOR:).