Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more info about setting up translate test. #2335

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Adding more info about setting up translate test. #2335

merged 1 commit into from
Sep 16, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 16, 2016

  1. @tseaver Didn't this have an issue somewhere?
  2. Should I move the env. var. into the environment_vars module? I originally elected not to since it is only used once and is testing only.

@dhermes dhermes added the api: translation Issues related to the Cloud Translation API API. label Sep 16, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 16, 2016

The issue was #2063. I closed it because I got past it, but this PR is better, because it helps non-core contributors. LGTM as-is.

@dhermes dhermes merged commit 11ca5bd into googleapis:master Sep 16, 2016
@dhermes dhermes deleted the more-info-about-translate-test branch September 16, 2016 18:23
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: translation Issues related to the Cloud Translation API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @daspecster @googlebot