Remove old/unused Bigtable v1 generated code#1999
Conversation
|
This PR would be a lot easier to read if broken up: e.g., first remove all the |
|
@tseaver It's broken up into 3 commits to accomplish essentially the same thing (but a little differently):
|
e23193c to
e7f265a
Compare
|
@tseaver PTAL |
|
@dhermes Your second commit couldn't possibly pass tests: the rename of the files has to go hand-in-hand with the updated imports. Could you squash it with the third commit? |
|
The failure was due to a newly introduced (hence not renamed) import from #2002. I made the commits as a group, not trying to get tests to pass in between. I avoided doing the import renames in the same commit as the file renames to make the diff easier to read. Having a "file rename only" commit makes the commit easier to grok. |
e7f265a to
5d8ec27
Compare
|
OK, LGTM. Looking forward to the day that we can rip this junk out, and just use the |
@tseaver there are a lot of import aliases leftover like:
Is it worth me tracking them down?