-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Impelement GAX logging API helper. #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impelement GAX logging API helper. #1884
Conversation
|
|
||
| import json | ||
|
|
||
| # pylint: disable=import-error |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Addresses: #1884 (comment)
|
How do we feel about the pragma/pylint overrides? |
I have very little respect the opinions involved in numerical limits in In testcase methods, For functions like For the import issues: if we ever get to the point that |
| :type entries: sequence of mapping | ||
| :param entries: the log entry resources to log. | ||
|
|
||
| :type logger_name: string |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Is this meant to be used with _LoggingAPI in /gcloud/logging/connection.py? I guess I'm trying to understand how people would use these together in practice? |
The class in this PR is the GAX -protobuf-over-gRPC alternative to that class, which is the JSON-over-HTTP version providing the same API. Only one of the two will be used in any given instance, based on a) importability of the gRPC-related modules, and b) an environment variable switch. That bit will get wired in in a subsequent PR, after implementing GAX versions of the |
|
Thanks! LGTM! |
No description provided.