Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Topic.set_iam_policy' API wrapper. #1641

Merged
merged 3 commits into from
Mar 22, 2016
Merged

Add 'Topic.set_iam_policy' API wrapper. #1641

merged 3 commits into from
Mar 22, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 21, 2016

Uses #1640 as a base.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 21, 2016

Hmm, odd docs build failure:

Warning, treated as error:

WARNING: intersphinx inventory 'http://oauth2client.readthedocs.org/en/latest/objects.inv' not fetchable due to <class 'urllib2.HTTPError'>: HTTP Error 500: Internal Server Error

ERROR: InvocationError: '/home/travis/build/GoogleCloudPlatform/gcloud-python/.tox/docs/bin/sphinx-build -W -b html -d docs/_build/doctrees docs docs/_build/html'

I've restarted the job.

@dhermes
Copy link
Contributor

dhermes commented Mar 21, 2016

Not weird. I've seen it from time to time. The objects.inv file is an inventory of all the objects in the library so that Sphinx can link across docs. The 500 just means the request failed.

@tseaver tseaver mentioned this pull request Mar 21, 2016
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Mar 22, 2016

@dhermes Rebased after merging #1640 to master. PTAL

dhermes
dhermes reviewed Mar 22, 2016
View reviewed changes
gcloud/pubsub/topic.py
@@ -278,6 +278,31 @@ def get_iam_policy(self, client=None):
resp = client.connection.api_request(method='GET', path=path)
return Policy.from_api_repr(resp)

def set_iam_policy(self, policy, client=None):
"""Update the IAM policy for the topic.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Mar 22, 2016
View reviewed changes
docs/pubsub-usage.rst
@@ -66,7 +66,7 @@ Delete a topic:
>>> topic = client.topic('topic_name')
>>> topic.delete() # API request

Fetch the IAM policy for a topic:
Update the IAM policy for a topic:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 22, 2016

LGTM other than the docs questions

tseaver added a commit that referenced this pull request Mar 22, 2016
@tseaver
Merge pull request #1641 from tseaver/pubsub-topic-set_iam_policy
aea1e6d 
Add 'Topic.set_iam_policy' API wrapper.
@tseaver tseaver merged commit aea1e6d into googleapis:master Mar 22, 2016
@tseaver tseaver deleted the pubsub-topic-set_iam_policy branch March 22, 2016 16:15
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot