Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage for gcloud.storage #144

Merged
merged 19 commits into from
Sep 23, 2014
Merged

Coverage for gcloud.storage #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
325a2d2
gcloud.connection: 57% -> 100% coverage.
tseaver Sep 2, 2014
ce96acf
gcloud.credentials: 0% -> 100% coverage.
tseaver Sep 2, 2014
f0bda75
Refactor test jigs for reuse.
tseaver Sep 2, 2014
67ce1cf
gcloud.storage: 40% -> 100% coverage.
tseaver Sep 18, 2014
06026b5
gcloud.storage.acl: 41% -> 59% coverage.
tseaver Sep 18, 2014
06a53e2
gcloud.storage.acl: 59% -> 84% coverage.
tseaver Sep 18, 2014
b15d1e4
Fix NameError in 'entity_from_dict' edge case.
tseaver Sep 18, 2014
29957ab
gcloud.storage.acl: 84% -> 92% coverage.
tseaver Sep 18, 2014
8fc67cf
gcloud.storage.acl: 92% -> 100% coverage.
tseaver Sep 18, 2014
1696a9a
gcloud.storage.bucket: 28% -> 100% coverage.
tseaver Sep 18, 2014
ab3e538
gcloud.storage.connection: 31% -> 100% coverage.
tseaver Sep 18, 2014
a099aab
gcloud.storage.exceptions: -> 100% coverage.
tseaver Sep 18, 2014
b14b6b2
gcloud.storage.iterator: 51% -> 65% coverage.
tseaver Sep 18, 2014
84c7b7d
Don't cover stub.
tseaver Sep 18, 2014
4c49023
Real assertions for BucketIterator / KeyIterator.
tseaver Sep 18, 2014
c7e576e
Hobgoblin.
tseaver Sep 18, 2014
4786c8a
gcloud.storage.iterator: 65% -> 100% coverage.
tseaver Sep 18, 2014
57a49f3
gcloud.storage.key: 34% -> 100% coverage.
tseaver Sep 19, 2014
117bca9
Don't try covering 'demo' subpackage.
tseaver Sep 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix NameError in 'entity_from_dict' edge case.
  • Loading branch information
@tseaver
tseaver committed Sep 18, 2014
commit b15d1e4571a9dc63a9215bd75262e0e34332d78e
2 changes: 1 addition & 1 deletion gcloud/storage/acl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def entity_from_dict(self, entity_dict):
entity = self.entity(type=type, identifier=identifier)

if not isinstance(entity, ACL.Entity):
raise ValueError('Invalid dictionary: %s' % acl_dict)
raise ValueError('Invalid dictionary: %s' % entity_dict)

return entity.grant(role)

Expand Down
7 changes: 7 additions & 0 deletions gcloud/storage/test_acl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,3 +182,10 @@ def test_entity_from_dict_string_w_hyphen(self):
self.assertEqual(entity.get_roles(), set([ROLE]))
self.assertEqual(list(acl),
[{'entity': 'type-id', 'role': ROLE}])

def test_entity_from_dict_string_wo_hyphen(self):
ROLE = 'role'
acl = self._makeOne()
self.assertRaises(ValueError,
acl.entity_from_dict,
{'entity': 'bogus', 'role': ROLE})