Add search indexes #1165
Merged
Add search indexes #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Ping me here when #1164 is in (or at least once that review is done) |
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| from gcloud.client import JSONClient | |||
| from gcloud.search.connection import Connection | |||
| from gcloud.search.index import Index | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Sorry for the delayed review. I accidentally knocked this PR out of my task queue. |
|
LGTM. (Would still like to know about CRUD ops on indexes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #1164 as a base.