Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bigquery): adjust test assertions to new default timeout #10222

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 29, 2020

Fixes #10221.

This PR adjusts a few unit test assertions to the new default timeout in core.

How to test

  • Run unit tests on the latest master branch.

Actual result (before the fix):
A few tests fail due to the timeout argument mismatch.

Expected result (after the fix):
All tests pass as they should.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added api: bigquery Issues related to the BigQuery API. type: process A process-related concern. May include testing, release, or the like. labels Jan 29, 2020
@plamut plamut requested a review from a team January 29, 2020 12:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
@plamut plamut merged commit fcdc10c into googleapis:master Jan 30, 2020
@plamut plamut deleted the iss-10221 branch January 30, 2020 06:59
This was referenced Jan 30, 2020
This was referenced Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Adjust unit tests to the new default connection timeout in core
3 participants