Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cloudbuild): fix syntax errors in synth.py #10077

Merged
merged 1 commit into from
Jan 9, 2020
Merged

chore(cloudbuild): fix syntax errors in synth.py #10077

merged 1 commit into from
Jan 9, 2020

Conversation

busunkim96
Copy link
Contributor

Fixes #9867

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
plamut
plamut approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit 20cf3b2 into googleapis:master Jan 9, 2020
@busunkim96 busunkim96 deleted the fix-cloudbuild-synth branch January 9, 2020 18:20
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
chore(cloudbuild): fix broken synth file (#10077)
da57629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesis failed for cloudbuild
3 participants
@busunkim96 @plamut @googlebot