Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove datastore.key._dataset_ids_equal and just use string equality check #821

Closed
dhermes opened this issue Apr 13, 2015 · 2 comments
Closed

Remove datastore.key._dataset_ids_equal and just use string equality check #821

dhermes opened this issue Apr 13, 2015 · 2 comments
Assignees
@dhermes
Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Milestone
Datastore Future

Comments

@dhermes
Copy link
Contributor

dhermes commented Apr 13, 2015

See #528 for some history here.

The issue is that requests made using foo instead of s~foo fail in strange ways.

So as a result we have to use datastore.helpers._prepare_key_for_request to strip dataset IDs from keys that get sent to the server. This has accidental caused bugs in the past (e.g. allowing keys from a different dataset bar to be inserted into dataset foo)
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Apr 13, 2015
@dhermes dhermes added this to the Datastore Future milestone Apr 13, 2015
@dhermes dhermes mentioned this issue Apr 13, 2015
Closed
@dhermes dhermes mentioned this issue Feb 13, 2016
Merged
@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@lukesneeringer
Copy link
Contributor

@dhermes Can you advise on this one?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 11, 2017 •
edited
Loading

@tseaver @lukesneeringer This is no longer relevant (I think because of changes made in the latest version of the API)

@dhermes dhermes closed this as completed Aug 11, 2017
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
feat: Update Compute Engine API to revision 20230701 (#421)
f01d17b 
* feat: Update Compute Engine API to revision 20230701 (#821)

Source-Link: googleapis/googleapis@761c3cb

Source-Link: googleapis/googleapis-gen@cac56a0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2FjNTZhMGVkZDExNzllOTI5YzMxZWJlYWFlODQ4N2YzODhkYzEwOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
Datastore Future
Development

No branches or pull requests
2 participants
@lukesneeringer @dhermes