Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language: support mention type in Entity.mentions. #3149

Closed
landrito opened this issue Mar 15, 2017 · 1 comment
Closed

Language: support mention type in Entity.mentions. #3149

landrito opened this issue Mar 15, 2017 · 1 comment
Assignees
@lukesneeringer
Labels
api: language Issues related to the Cloud Natural Language API API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. release blocking Required feature/issue must be fixed prior to next release.

Comments

@landrito
Copy link
Contributor

Currently the mentions property of an entity is only a list of strings whereas it should be a list of objects containing the mention text and mention type.

Furthermore, this change should add mention_type information to the mention documentation.
@landrito landrito added api: language Issues related to the Cloud Natural Language API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. status: acknowledged labels Mar 15, 2017
@lukesneeringer
Copy link
Contributor

Adding the release blocking tag; this is a beta blocker.

@lukesneeringer lukesneeringer added priority: p0 Highest priority. Critical issue. P0 implies highest priority. release blocking Required feature/issue must be fixed prior to next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 15, 2017
lukesneeringer pushed a commit to lukesneeringer/google-cloud-python that referenced this issue Mar 16, 2017
Provide full Mention objects, not just the content.
1d2e49f 
Fixes googleapis#3149.
@lukesneeringer lukesneeringer mentioned this issue Mar 16, 2017
Merged
lukesneeringer added a commit that referenced this issue Mar 16, 2017
@lukesneeringer
Provide full Mention objects, not just the content. (#3156)
69e2b53 
Fixes #3149.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this issue May 6, 2017
@lukesneeringer
Provide full Mention objects, not just the content. (googleapis#3156)
e135dba 
Fixes googleapis#3149.
parthea pushed a commit that referenced this issue Jul 6, 2023
@lukesneeringer
Provide full Mention objects, not just the content. (#3156)
841002d 
Fixes #3149.
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot @busunkim96
chore(deps): update dependency google-cloud-asset to v0.9.0 [(#3149)](G…
7655b7c 
…oogleCloudPlatform/python-docs-samples#3149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
api: language Issues related to the Cloud Natural Language API API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukesneeringer @landrito