Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud speech veneer should not provide a default sample rate #2948

Closed
pbogle opened this issue Jan 18, 2017 · 1 comment
Closed

Cloud speech veneer should not provide a default sample rate #2948

pbogle opened this issue Jan 18, 2017 · 1 comment
Assignees
@yoshi-automation
Labels
api: speech Issues related to the Speech-to-Text API. release blocking Required feature/issue must be fixed prior to next release.

Comments

@pbogle
Copy link

pbogle commented Jan 18, 2017

Default sample rates should be removed. For audio types with a header the server can automatically determine the sample rate. (We are implementing this for V1.) For audio types without a header the default causes more harm than good because if it is incorrect the results could be empty or wildly inaccurate, which causes user confusion.
@pbogle
Copy link
Author

pbogle commented Jan 18, 2017

The same applies to language code.

@daspecster daspecster added the api: speech Issues related to the Speech-to-Text API. label Jan 18, 2017
@daspecster daspecster self-assigned this Jan 20, 2017
@danoscarmike danoscarmike added the release blocking Required feature/issue must be fixed prior to next release. label Jan 25, 2017
@danoscarmike danoscarmike added this to the Beta Code Complete milestone Jan 25, 2017
lukesneeringer added a commit to lukesneeringer/google-cloud-python that referenced this issue Jan 25, 2017
@lukesneeringer
Remove default sample_rate.
89e6056 
Fixes googleapis#2948.
@lukesneeringer lukesneeringer mentioned this issue Jan 25, 2017
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this issue May 6, 2017
@lukesneeringer
Remove default sample_rate.
b688719 
Fixes googleapis#2948.
atulep pushed a commit that referenced this issue Apr 3, 2023
@lukesneeringer
Remove default sample_rate.
3c04766 
Fixes #2948.
atulep pushed a commit that referenced this issue Apr 18, 2023
@lukesneeringer
Remove default sample_rate.
938436c 
Fixes #2948.
parthea pushed a commit that referenced this issue Oct 22, 2023
@lukesneeringer
Remove default sample_rate.
756f076 
Fixes #2948.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: speech Issues related to the Speech-to-Text API. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daspecster @danoscarmike @pbogle @yoshi-automation