Skip to content

Should language document_from_text() etc. be a reference to the Document class #2183

Closed
@dhermes

Description

See https://github.com/GoogleCloudPlatform/gcloud-python/pull/2062/files/d36ad4db94666450786d4f667aea0607ff2113cb#r76032786

The question is whether we should have Client.document_from_foo methods or just have Client.document be a reference to the class Document and then use Client.document.from_foo.

This amounts to swapping _ for . (i.e. no less typing) and makes a "proper noun" like Document be referenced as an "improper noun" as a property, which is not a win IMO

Metadata

Labels

api: languageIssues related to the Cloud Natural Language API API.priority: p2Moderately-important priority. Fix may not be included in next release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions