Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation Issue] #1662

Closed
sirtux opened this issue Mar 25, 2016 · 1 comment
Closed

[Documentation Issue] #1662

sirtux opened this issue Mar 25, 2016 · 1 comment
Assignees
@dhermes
Labels
api: dns Issues related to the Cloud DNS API.

Comments

@sirtux
Copy link

sirtux commented Mar 25, 2016

Page Name: dns-usage
Release: 0.11.0

On https://googlecloudplatform.github.io/gcloud-python/stable/dns-usage.html#resource-record-sets,

there is an example:

[(record.name, record.type, record.ttl, record.rrdatas) for record in records]

the correct version would be:

[(record.name, record.record_type, record.ttl, record.rrdatas) for record in records]

as record doesn't have a attribute type, but record_type.
@dhermes dhermes added the api: dns Issues related to the Cloud DNS API. label Mar 25, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 25, 2016

Thanks for filing!

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Mar 25, 2016
@dhermes
Renaming type->record_type in DNS doc.
509137a 
Fixes googleapis#1662.
@dhermes dhermes mentioned this issue Mar 25, 2016
Merged
@dhermes dhermes added the docs label Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: dns Issues related to the Cloud DNS API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhermes @sirtux