In storage.connection.Connection.get_bucket, determine if sending non-URL-encoded bucket name is safe

[dhermes]

From TODO:

    # TODO: URL-encode the bucket name to be safe?

See storage.connection.Connection.get_bucket for relevant code and #146 for some context.

git blame output

b7f1b774 (JJ Geewax   2014-01-29 18:02:29 -0500 286)     # TODO: URL-encode the bucket name to be safe?

[tseaver]

See the API requirements for bucket names. URL encoding isn't really the right check.

Note the BucketNameUnavailable error under 409 Conflict in the HTTP status codes API doc: it appears that the back-end will check / enforce the requirements.

[tseaver]

@silvolu @jgeewax I recommend closing this issue.

[tseaver]

I take it back: see #354. In particular, / is a valid character in an object name: we need to urlencode the name to support that.

[tseaver]

Oy, #354 is about object names, not bucket names.

[jgeewax]

Yes, you're correct. For bucket names, escapable characters shouldn't be valid anyway. For objects, slashes are an issue. I think you're correct that we should close the issue.