fix: Add async context manager return types (#539)

* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Jul 4, 2023 · fdee40a · fdee40a
1 parent a045743
commit fdee40a
Show file tree

Hide file tree

Showing 16 changed files with 61 additions and 37 deletions.
diff --git a/packages/google-cloud-vision/google/cloud/vision_v1/services/image_annotator/async_client.py b/packages/google-cloud-vision/google/cloud/vision_v1/services/image_annotator/async_client.py
@@ -720,7 +720,7 @@ async def sample_async_batch_annotate_files():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ImageAnnotatorAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/packages/google-cloud-vision/google/cloud/vision_v1/services/product_search/async_client.py b/packages/google-cloud-vision/google/cloud/vision_v1/services/product_search/async_client.py
@@ -2743,7 +2743,7 @@ async def sample_purge_products():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ProductSearchAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...oogle-cloud-vision/google/cloud/vision_v1p1beta1/services/image_annotator/async_client.py b/...oogle-cloud-vision/google/cloud/vision_v1p1beta1/services/image_annotator/async_client.py
@@ -324,7 +324,7 @@ async def sample_batch_annotate_images():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ImageAnnotatorAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...oogle-cloud-vision/google/cloud/vision_v1p2beta1/services/image_annotator/async_client.py b/...oogle-cloud-vision/google/cloud/vision_v1p2beta1/services/image_annotator/async_client.py
@@ -457,7 +457,7 @@ async def sample_async_batch_annotate_files():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ImageAnnotatorAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...oogle-cloud-vision/google/cloud/vision_v1p3beta1/services/image_annotator/async_client.py b/...oogle-cloud-vision/google/cloud/vision_v1p3beta1/services/image_annotator/async_client.py
@@ -458,7 +458,7 @@ async def sample_async_batch_annotate_files():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ImageAnnotatorAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...google-cloud-vision/google/cloud/vision_v1p3beta1/services/product_search/async_client.py b/...google-cloud-vision/google/cloud/vision_v1p3beta1/services/product_search/async_client.py
@@ -2592,7 +2592,7 @@ async def sample_import_product_sets():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ProductSearchAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...oogle-cloud-vision/google/cloud/vision_v1p4beta1/services/image_annotator/async_client.py b/...oogle-cloud-vision/google/cloud/vision_v1p4beta1/services/image_annotator/async_client.py
@@ -708,7 +708,7 @@ async def sample_async_batch_annotate_files():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ImageAnnotatorAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...google-cloud-vision/google/cloud/vision_v1p4beta1/services/product_search/async_client.py b/...google-cloud-vision/google/cloud/vision_v1p4beta1/services/product_search/async_client.py
@@ -2728,7 +2728,7 @@ async def sample_purge_products():
         # Done; return the response.
         return response
 
-    async def __aenter__(self):
+    async def __aenter__(self) -> "ProductSearchAsyncClient":
         return self
 
     async def __aexit__(self, exc_type, exc, tb):

diff --git a/...oogle-cloud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1.json b/...oogle-cloud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-vision",
-    "version": "3.4.3"
+    "version": "0.1.0"
   },
   "snippets": [
     {

diff --git a/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p1beta1.json b/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p1beta1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-vision",
-    "version": "3.4.3"
+    "version": "0.1.0"
   },
   "snippets": [
     {

diff --git a/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p2beta1.json b/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p2beta1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-vision",
-    "version": "3.4.3"
+    "version": "0.1.0"
   },
   "snippets": [
     {

diff --git a/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p3beta1.json b/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p3beta1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-vision",
-    "version": "3.4.3"
+    "version": "0.1.0"
   },
   "snippets": [
     {

diff --git a/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p4beta1.json b/...loud-vision/samples/generated_samples/snippet_metadata_google.cloud.vision.v1p4beta1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-vision",
-    "version": "3.4.3"
+    "version": "0.1.0"
   },
   "snippets": [
     {

diff --git a/packages/google-cloud-vision/tests/unit/gapic/vision_v1/test_product_search.py b/packages/google-cloud-vision/tests/unit/gapic/vision_v1/test_product_search.py
@@ -1424,9 +1424,11 @@ async def test_list_product_sets_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_product_sets(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -2843,9 +2845,11 @@ async def test_list_products_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_products(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -4521,9 +4525,11 @@ async def test_list_reference_images_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_reference_images(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -5705,9 +5711,11 @@ async def test_list_products_in_product_set_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_products_in_product_set(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token

diff --git a/packages/google-cloud-vision/tests/unit/gapic/vision_v1p3beta1/test_product_search.py b/packages/google-cloud-vision/tests/unit/gapic/vision_v1p3beta1/test_product_search.py
@@ -1425,9 +1425,11 @@ async def test_list_product_sets_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_product_sets(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -2844,9 +2846,11 @@ async def test_list_products_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_products(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -4522,9 +4526,11 @@ async def test_list_reference_images_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_reference_images(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -5706,9 +5712,11 @@ async def test_list_products_in_product_set_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_products_in_product_set(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token

diff --git a/packages/google-cloud-vision/tests/unit/gapic/vision_v1p4beta1/test_product_search.py b/packages/google-cloud-vision/tests/unit/gapic/vision_v1p4beta1/test_product_search.py
@@ -1426,9 +1426,11 @@ async def test_list_product_sets_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_product_sets(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -2845,9 +2847,11 @@ async def test_list_products_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_products(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -4523,9 +4527,11 @@ async def test_list_reference_images_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_reference_images(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token
@@ -5707,9 +5713,11 @@ async def test_list_products_in_product_set_async_pages():
             RuntimeError,
         )
         pages = []
-        async for page_ in (
+        # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
+        # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
+        async for page_ in (  # pragma: no branch
             await client.list_products_in_product_set(request={})
-        ).pages:  # pragma: no branch
+        ).pages:
             pages.append(page_)
         for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
             assert page_.raw_page.next_page_token == token