Skip to content

Commit eec6e9f

Browse files
committed
Updating datastore system tests to use new iterator.
1 parent 845efc9 commit eec6e9f

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

system_tests/clear_datastore.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,8 @@ def fetch_keys(kind, client, fetch_max=FETCH_MAX, query=None, cursor=None):
4545
query.keys_only()
4646

4747
iterator = query.fetch(limit=fetch_max, start_cursor=cursor)
48-
49-
entities, _, cursor = iterator.next_page()
50-
return query, entities, cursor
48+
page = six.next(iterator.pages)
49+
return query, list(page), iterator.next_page_token
5150

5251

5352
def get_ancestors(entities):

system_tests/datastore.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import unittest
1818

1919
import httplib2
20+
import six
2021

2122
from google.cloud._helpers import UTC
2223
from google.cloud import datastore
@@ -260,14 +261,16 @@ def test_limit_queries(self):
260261

261262
# Fetch characters.
262263
iterator = query.fetch(limit=limit)
263-
character_entities, _, cursor = iterator.next_page()
264+
page = six.next(iterator.pages)
265+
character_entities = list(page)
266+
cursor = iterator.next_page_token
264267
self.assertEqual(len(character_entities), limit)
265268

266269
# Check cursor after fetch.
267270
self.assertIsNotNone(cursor)
268271

269-
# Fetch remaining of characters.
270-
new_character_entities = list(iterator)
272+
# Fetch remaining characters.
273+
new_character_entities = list(query.fetch(start_cursor=cursor))
271274
characters_remaining = len(self.CHARACTERS) - limit
272275
self.assertEqual(len(new_character_entities), characters_remaining)
273276

@@ -362,7 +365,9 @@ def test_query_paginate_with_offset(self):
362365
iterator = page_query.fetch(limit=limit, offset=offset)
363366

364367
# Fetch characters.
365-
entities, _, cursor = iterator.next_page()
368+
page = six.next(iterator.pages)
369+
entities = list(page)
370+
cursor = iterator.next_page_token
366371
self.assertEqual(len(entities), limit)
367372
self.assertEqual(entities[0]['name'], 'Robb')
368373
self.assertEqual(entities[1]['name'], 'Bran')
@@ -385,7 +390,9 @@ def test_query_paginate_with_start_cursor(self):
385390
iterator = page_query.fetch(limit=limit, offset=offset)
386391

387392
# Fetch characters.
388-
entities, _, cursor = iterator.next_page()
393+
page = six.next(iterator.pages)
394+
entities = list(page)
395+
cursor = iterator.next_page_token
389396
self.assertEqual(len(entities), limit)
390397

391398
# Use cursor to create a fresh query.

0 commit comments

Comments
 (0)