Skip to content

Commit 845efc9

Browse files
committed
Renaming datastore AltIterator-->Iterator.
1 parent a3f68a4 commit 845efc9

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

datastore/google/cloud/datastore/query.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -358,20 +358,20 @@ def fetch(self, limit=None, offset=0, start_cursor=None, end_cursor=None,
358358
:param client: client used to connect to datastore.
359359
If not supplied, uses the query's value.
360360
361-
:rtype: :class:`AltIterator`
361+
:rtype: :class:`Iterator`
362362
:returns: The iterator for the query.
363363
:raises: ValueError if ``connection`` is not passed and no implicit
364364
default has been set.
365365
"""
366366
if client is None:
367367
client = self._client
368368

369-
return AltIterator(
369+
return Iterator(
370370
self, client, limit=limit, offset=offset,
371371
start_cursor=start_cursor, end_cursor=end_cursor)
372372

373373

374-
class AltIterator(BaseIterator):
374+
class Iterator(BaseIterator):
375375
"""Represent the state of a given execution of a Query.
376376
377377
:type query: :class:`~google.cloud.datastore.query.Query`
@@ -399,7 +399,7 @@ class AltIterator(BaseIterator):
399399

400400
def __init__(self, query, client, limit=None, offset=None,
401401
start_cursor=None, end_cursor=None):
402-
super(AltIterator, self).__init__(
402+
super(Iterator, self).__init__(
403403
client=client, item_to_value=_item_to_entity,
404404
page_token=start_cursor, max_results=limit)
405405
self._query = query

datastore/unit_tests/test_query.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -309,39 +309,39 @@ def test_distinct_on_multiple_calls(self):
309309
self.assertEqual(query.distinct_on, _DISTINCT_ON2)
310310

311311
def test_fetch_defaults_w_client_attr(self):
312-
from google.cloud.datastore.query import AltIterator
312+
from google.cloud.datastore.query import Iterator
313313

314314
connection = _Connection()
315315
client = self._makeClient(connection)
316316
query = self._makeOne(client)
317317
iterator = query.fetch()
318318

319-
self.assertIsInstance(iterator, AltIterator)
319+
self.assertIsInstance(iterator, Iterator)
320320
self.assertIs(iterator._query, query)
321321
self.assertIs(iterator.client, client)
322322
self.assertIsNone(iterator.max_results)
323323
self.assertEqual(iterator._offset, 0)
324324

325325
def test_fetch_w_explicit_client(self):
326-
from google.cloud.datastore.query import AltIterator
326+
from google.cloud.datastore.query import Iterator
327327

328328
connection = _Connection()
329329
client = self._makeClient(connection)
330330
other_client = self._makeClient(connection)
331331
query = self._makeOne(client)
332332
iterator = query.fetch(limit=7, offset=8, client=other_client)
333-
self.assertIsInstance(iterator, AltIterator)
333+
self.assertIsInstance(iterator, Iterator)
334334
self.assertIs(iterator._query, query)
335335
self.assertIs(iterator.client, other_client)
336336
self.assertEqual(iterator.max_results, 7)
337337
self.assertEqual(iterator._offset, 8)
338338

339339

340-
class TestAltIterator(unittest.TestCase):
340+
class TestIterator(unittest.TestCase):
341341

342342
def _getTargetClass(self):
343-
from google.cloud.datastore.query import AltIterator
344-
return AltIterator
343+
from google.cloud.datastore.query import Iterator
344+
return Iterator
345345

346346
def _makeOne(self, *args, **kw):
347347
return self._getTargetClass()(*args, **kw)

0 commit comments

Comments
 (0)