Skip to content

Commit

Permalink
chore: prevent normalization of semver versioning (#137)
Browse files Browse the repository at this point in the history
When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from `-patch` to `.patch` which is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.
  • Loading branch information
dandhlee authored Apr 16, 2021
1 parent 2aa8354 commit a9ff7e8
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion packages/google-cloud-vision/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@

import setuptools

# Disable version normalization performed by setuptools.setup()
try:
# Try the approach of using sic(), added in setuptools 46.1.0
from setuptools import sic
except ImportError:
# Try the approach of replacing packaging.version.Version
sic = lambda v: v
try:
# setuptools >=39.0.0 uses packaging from setuptools.extern
from setuptools.extern import packaging
except ImportError:
# setuptools <39.0.0 uses packaging from pkg_resources.extern
from pkg_resources.extern import packaging
packaging.version.Version = packaging.version.LegacyVersion

name = "google-cloud-vision"
description = "Cloud Vision API API client library"
version = "2.3.1"
Expand Down Expand Up @@ -46,7 +61,7 @@

setuptools.setup(
name=name,
version=version,
version=sic(version),
description=description,
long_description=readme,
author="Google LLC",
Expand Down

0 comments on commit a9ff7e8

Please sign in to comment.