Skip to content

Commit

Permalink
fix(logging): update test assertion and core version pins (#10087)
Browse files Browse the repository at this point in the history
* Adjust request params assertion in test (timeout)

* Update version pins for core dependencies

Version bumps are needed, as timeouts were introduced to API core.

* Adjust assertion in system test

An empty zone label that was missing is added.
  • Loading branch information
plamut authored Jan 10, 2020
1 parent 240f381 commit 70fe9b4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions logging/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
# 'Development Status :: 5 - Production/Stable'
release_status = 'Development Status :: 5 - Production/Stable'
dependencies = [
"google-api-core[grpc] >= 1.14.0, < 2.0.0dev",
"google-cloud-core >= 1.0.3, < 2.0dev",
"google-api-core[grpc] >= 1.15.0, < 2.0.0dev",
"google-cloud-core >= 1.1.0, < 2.0dev",
]
extras = {
}
Expand Down
3 changes: 2 additions & 1 deletion logging/tests/system/test_system.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def test_log_text_with_resource(self):
logger = Config.CLIENT.logger(self._logger_name("log_text_res"))
now = datetime.datetime.utcnow()
resource = Resource(
type="gae_app", labels={"module_id": "default", "version_id": "test"}
type="gae_app",
labels={"module_id": "default", "version_id": "test", "zone": ""},
)

self.to_delete.append(logger)
Expand Down
6 changes: 5 additions & 1 deletion logging/tests/unit/test__http.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ def test_extra_headers(self):
}
expected_uri = conn.build_api_url("/rainbow")
http.request.assert_called_once_with(
data=req_data, headers=expected_headers, method="GET", url=expected_uri
data=req_data,
headers=expected_headers,
method="GET",
url=expected_uri,
timeout=None,
)


Expand Down

0 comments on commit 70fe9b4

Please sign in to comment.