Merge pull request #1600 from tseaver/logging-sink_delete

Add 'Sink.delete' API wrapper.
googleapis · Mar 12, 2016 · 6e6a9c4 · 6e6a9c4
2 parents b51de13 + 6407219
commit 6e6a9c4
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/gcloud/logging/sink.py b/gcloud/logging/sink.py
@@ -144,3 +144,16 @@ def update(self, client=None):
             'destination': self.destination,
         }
         client.connection.api_request(method='PUT', path=self.path, data=data)
+
+    def delete(self, client=None):
+        """API call:  delete a sink via a DELETE request
+
+        See
+        https://cloud.google.com/logging/docs/api/ref_v2beta1/rest/v2beta1/projects.sinks/delete
+
+        :type client: :class:`gcloud.logging.client.Client` or ``NoneType``
+        :param client: the client to use.  If not passed, falls back to the
+                       ``client`` stored on the current sink.
+        """
+        client = self._require_client(client)
+        client.connection.api_request(method='DELETE', path=self.path)
diff --git a/gcloud/logging/test_sink.py b/gcloud/logging/test_sink.py
@@ -193,6 +193,33 @@ def test_update_w_alternate_client(self):
         self.assertEqual(req['path'], '/%s' % FULL)
         self.assertEqual(req['data'], RESOURCE)
 
+    def test_delete_w_bound_client(self):
+        FULL = 'projects/%s/sinks/%s' % (self.PROJECT, self.SINK_NAME)
+        conn = _Connection({})
+        CLIENT = _Client(project=self.PROJECT, connection=conn)
+        sink = self._makeOne(self.SINK_NAME, self.FILTER, self.DESTINATION_URI,
+                             client=CLIENT)
+        sink.delete()
+        self.assertEqual(len(conn._requested), 1)
+        req = conn._requested[0]
+        self.assertEqual(req['method'], 'DELETE')
+        self.assertEqual(req['path'], '/%s' % FULL)
+
+    def test_delete_w_alternate_client(self):
+        FULL = 'projects/%s/sinks/%s' % (self.PROJECT, self.SINK_NAME)
+        conn1 = _Connection()
+        CLIENT1 = _Client(project=self.PROJECT, connection=conn1)
+        conn2 = _Connection({})
+        CLIENT2 = _Client(project=self.PROJECT, connection=conn2)
+        sink = self._makeOne(self.SINK_NAME, self.FILTER, self.DESTINATION_URI,
+                             client=CLIENT1)
+        sink.delete(client=CLIENT2)
+        self.assertEqual(len(conn1._requested), 0)
+        self.assertEqual(len(conn2._requested), 1)
+        req = conn2._requested[0]
+        self.assertEqual(req['method'], 'DELETE')
+        self.assertEqual(req['path'], '/%s' % FULL)
+
 
 class _Connection(object):