Making regression test put()'s transactional.

Also removing AssertionError from list of retry classes.
googleapis · Jan 19, 2015 · 280b7ac · 280b7ac
1 parent a060dc7
commit 280b7ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/regression/datastore.py b/regression/datastore.py
@@ -80,7 +80,8 @@ def _get_post(self, id_or_name=None, post_content=None):
 
     def _generic_test_post(self, name=None, key_id=None):
         entity = self._get_post(id_or_name=(name or key_id))
-        datastore.put([entity])
+        with datastore.Transaction():
+            datastore.put([entity])
 
         # Register entity to be deleted.
         self.case_entities_to_delete.append(entity)
@@ -149,7 +150,8 @@ def test_save_key_self_reference(self):
         entity['fullName'] = u'Full name'
         entity['linkedTo'] = key  # Self reference.
 
-        datastore.put([entity])
+        with datastore.Transaction():
+            datastore.put([entity])
         self.case_entities_to_delete.append(entity)
 
         query = datastore.Query(kind='Person')

diff --git a/regression/regression_utils.py b/regression/regression_utils.py
@@ -36,7 +36,7 @@
 class RetryTestsMetaclass(type):
 
     NUM_RETRIES = 2
-    FLAKY_ERROR_CLASSES = (AssertionError, NotFound)
+    FLAKY_ERROR_CLASSES = (NotFound,)
 
     @staticmethod
     def _wrap_class_attr(class_attr):