Skip to content

Commit

Permalink
chore: remove 2.7 from samples noxfile (#106)
Browse files Browse the repository at this point in the history
  • Loading branch information
yoshi-automation authored Aug 16, 2021
1 parent be1455a commit 0440a52
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 8 deletions.
12 changes: 9 additions & 3 deletions packages/google-cloud-compute/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,15 @@ def default(session):
constraints_path = str(
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
)
session.install("asyncmock", "pytest-asyncio", "-c", constraints_path)

session.install("mock", "pytest", "pytest-cov", "-c", constraints_path)
session.install(
"mock",
"asyncmock",
"pytest",
"pytest-cov",
"pytest-asyncio",
"-c",
constraints_path,
)

session.install("-e", ".", "-c", constraints_path)

Expand Down
6 changes: 3 additions & 3 deletions packages/google-cloud-compute/samples/snippets/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

TEST_CONFIG = {
# You can opt out from the test for specific Python versions.
'ignored_versions': ["2.7"],
'ignored_versions': [],

# Old samples are opted out of enforcing Python type hints
# All new samples should feature them
Expand Down Expand Up @@ -88,8 +88,8 @@ def get_pytest_env_vars() -> Dict[str, str]:


# DO NOT EDIT - automatically generated.
# All versions used to tested samples.
ALL_VERSIONS = ["2.7", "3.6", "3.7", "3.8", "3.9"]
# All versions used to test samples.
ALL_VERSIONS = ["3.6", "3.7", "3.8", "3.9"]

# Any default versions that should be ignored.
IGNORED_VERSIONS = TEST_CONFIG['ignored_versions']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Install Dependencies
.. _Python Development Environment Setup Guide:
https://cloud.google.com/python/setup

#. Create a virtualenv. Samples are compatible with Python 2.7 and 3.4+.
#. Create a virtualenv. Samples are compatible with Python 3.6+.

.. code-block:: bash
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-compute/synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/python-compute.git",
"sha": "db0404c7849147dcc5bafe797e23cdb5364b381b"
"sha": "2eca2f305dea26c03703a618061bec8f2b6bf316"
}
},
{
Expand Down

0 comments on commit 0440a52

Please sign in to comment.