storage: getSigned*: clear up expiration format #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

callmehiphop merged 1 commit into googleapis:master from stephenplusplus:spp--storage-expiration-correction

Aug 31, 2015

Contributor

stephenplusplus commented Aug 30, 2015

Fixes #834

Formerly:

getSignedPolicy - options.expiration - Advertised as seconds, handled by our code as milliseconds
getSignedUrl - options.expires - Advertised as seconds, handled by the API directly as seconds

Now:

getSignedPolicy - options.expires - Advertised as anything Date accepts
getSignedUrl - options.expires - Advertised as anything Date accepts

Also added a system test for getSignedPolicy, which we didn't have previously.

googlebot added the cla: yes label

stephenplusplus added the api: storage label

jgeewax reviewed

View reviewed changes

lib/storage/file.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Contributor

jgeewax commented Aug 30, 2015

LGTM

callmehiphop reviewed

View reviewed changes

lib/storage/file.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--storage-expiration-correction branch from 719b2f5 to 412b4e9 Compare

August 31, 2015 13:46

Contributor Author

stephenplusplus commented Aug 31, 2015

Updated to accept anything Date accepts.

callmehiphop reviewed

View reviewed changes

lib/storage/file.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view


          storage: getSigned*: clear up expiration format

432777e

stephenplusplus force-pushed the spp--storage-expiration-correction branch from 412b4e9 to 432777e Compare

August 31, 2015 17:14

Contributor Author

stephenplusplus commented Aug 31, 2015

The docs test timed out after 2s. I restarted travis, it failed. Restarted again and it passed. Maybe that needs to be bumped up? Wait til it consistently becomes an issue?

callmehiphop added a commit that referenced this pull request


          Merge pull request #835 from stephenplusplus/spp--storage-expiration-…

a4a19b8

…correction

storage: getSigned*: clear up expiration format

callmehiphop merged commit a4a19b8 into googleapis:master

Contributor

callmehiphop commented Aug 31, 2015

Sure, that sounds like a good plan.

stephenplusplus mentioned this pull request

storage: allow more time for signed urls to expire #839

Merged

callmehiphop mentioned this pull request

tests: docs: increased timeout to 5 seconds for doc testing #840

Merged

miguelvelezsa pushed a commit that referenced this pull request


          chore: release 2.4.1 (#835)

bf88ae7

* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

9ab6eee

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

28e842d

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

4f09fea

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

e9dcdf7

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

475d2d1

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

d64bf62

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

56c7708

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

907d687

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

9bb029e

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

9cf4cf6

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

6b42bbd

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

c20a497

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

0d03958

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

904b5cf

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sofisl added a commit that referenced this pull request


          build!: update library to use Node 12 (#835)

40d606a

* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests

sofisl pushed a commit that referenced this pull request


          chore(main): release 5.0.0 (#839)

274ee4f

🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage cla: yes