storage: use hash-stream-validation #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
added
api: storage
| mockery.registerMock('sse4_crc32', crc); | ||
| // If we don't stub see4_crc32 and use mockery, we get "Module did not self- | ||
| // register". | ||
| var crc32c = require('hash-stream-validation/node_modules/sse4_crc32'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--storage-stream-cleaning
branch
from
0d93bd1
to
ec1ae05
Compare
googlebot
added
the
cla: yes
|
Fixed the merge conflict. LMK if you have any questions. |
stephenplusplus
force-pushed
the
spp--storage-stream-cleaning
branch
from
ec1ae05
to
55872da
Compare
callmehiphop
added a commit
that referenced
this pull request
Aug 26, 2015
…ning storage: use hash-stream-validation
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
* chore: use gapic-generator-typescript v2.17.0 PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: fix translation Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <fenster@google.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.3](googleapis/nodejs-translate@v7.0.2...v7.0.3) (2022-09-22) ### Bug Fixes * Allow passing gax instance to client constructor ([#814](googleapis/nodejs-translate#814)) ([ddc93f9](googleapis/nodejs-translate@ddc93f9)) * **deps:** Update dependency @google-cloud/vision to v3 ([#816](googleapis/nodejs-translate#816)) ([331c65b](googleapis/nodejs-translate@331c65b)) * Preserve default values in x-goog-request-params header ([#820](googleapis/nodejs-translate#820)) ([913ac11](googleapis/nodejs-translate@913ac11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
…820) Source-Author: Benjamin E. Coe <bencoe@google.com> Source-Date: Wed Aug 26 14:28:22 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9 Source-Link: googleapis/synthtool@8cf6d28
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 30, 2023
Source-Link: googleapis/googleapis@4e5d66b Source-Link: googleapis/googleapis-gen@7fcb354 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjdmY2IzNTQ1OWZhOWIzYmZiOWNkOWJlYmM0YTI1OWQ3ZWZlYWI1OWYifQ==
ddelgrosso1
added a commit
that referenced
this pull request
Jul 6, 2023
…#4388) * feat: Update Compute Engine API to revision 20230610 (#820) Source-Link: googleapis/googleapis@4e5d66b Source-Link: googleapis/googleapis-gen@7fcb354 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjdmY2IzNTQ1OWZhOWIzYmZiOWNkOWJlYmM0YTI1OWQ3ZWZlYWI1OWYifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #400
I moved the hashing logic out to a module in an attempt to simplify what our library needs to worry about doing.
https://github.com/stephenplusplus/hash-stream-validation