fix: [merchantapi] Changed repeated flag of an existing field gtin in message .google.shopping.merchant.products.v1beta.Attributes
#5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
…google.shopping.merchant.products.v1beta.Attributes` fix!: An existing field `gtin` is moved out of oneof in message `.google.shopping.merchant.products.v1beta.Attributes` docs: A comment for message `ProductInput` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.ProductInput` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.DeleteProductInputRequest` is changed docs: A comment for message `Product` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.Product` is changed docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.GetProductRequest` is changed docs: A comment for field `page_size` in message `.google.shopping.merchant.products.v1beta.ListProductsRequest` is changed docs: A comment for field `gtin` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed docs: A comment for field `tax_category` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed docs: A comment for field `min_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed docs: A comment for field `max_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed docs: A comment for field `min_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed docs: A comment for field `max_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed feat: A new field `member_price_effective_date` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram` feat: A new field `shipping_label` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram` PiperOrigin-RevId: 704281512 Source-Link: googleapis/googleapis@0f1beb9 Source-Link: googleapis/googleapis-gen@5429d7d Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLXNob3BwaW5nLW1lcmNoYW50LXByb2R1Y3RzLy5Pd2xCb3QueWFtbCIsImgiOiI1NDI5ZDdkNDBiMjQ4YWQwMzQ3ZTkxNmRlZmVlMTdiYTUxMTY0MDExIn0=
|
/gcbrun |
gcf-owl-bot
bot
requested review from
yoshi-approver and
a team
as code owners
|
/gcbrun |
d-goog
added
the
do not merge
sofisl
removed
the
do not merge
|
Even though this is breaking, it is OK to merge this since it is in the beta surface. Also, shopping has slightly different processes than cloud when it comes to breaking changes. |
sofisl
approved these changes
Dec 17, 2024
sofisl
changed the title
gtin in message .google.shopping.merchant.products.v1beta.Attributesgtin in message .google.shopping.merchant.products.v1beta.Attributes
sofisl
deleted the
owl-bot-copy-packages-google-shopping-merchant-products
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix!: An existing field
gtinis moved out of oneof in message.google.shopping.merchant.products.v1beta.Attributesdocs: A comment for message
ProductInputis changeddocs: A comment for field
namein message.google.shopping.merchant.products.v1beta.ProductInputis changeddocs: A comment for field
namein message.google.shopping.merchant.products.v1beta.DeleteProductInputRequestis changeddocs: A comment for message
Productis changeddocs: A comment for field
namein message.google.shopping.merchant.products.v1beta.Productis changeddocs: A comment for field
namein message.google.shopping.merchant.products.v1beta.GetProductRequestis changeddocs: A comment for field
page_sizein message.google.shopping.merchant.products.v1beta.ListProductsRequestis changeddocs: A comment for field
gtinin message.google.shopping.merchant.products.v1beta.Attributesis changeddocs: A comment for field
tax_categoryin message.google.shopping.merchant.products.v1beta.Attributesis changeddocs: A comment for field
min_handling_timein message.google.shopping.merchant.products.v1beta.Shippingis changeddocs: A comment for field
max_handling_timein message.google.shopping.merchant.products.v1beta.Shippingis changeddocs: A comment for field
min_transit_timein message.google.shopping.merchant.products.v1beta.Shippingis changeddocs: A comment for field
max_transit_timein message.google.shopping.merchant.products.v1beta.Shippingis changedfeat: A new field
member_price_effective_dateis added to message.google.shopping.merchant.products.v1beta.LoyaltyProgramfeat: A new field
shipping_labelis added to message.google.shopping.merchant.products.v1beta.LoyaltyProgramPiperOrigin-RevId: 704281512
Source-Link: googleapis/googleapis@0f1beb9
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5429d7d40b248ad0347e916defee17ba51164011
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLXNob3BwaW5nLW1lcmNoYW50LXByb2R1Y3RzLy5Pd2xCb3QueWFtbCIsImgiOiI1NDI5ZDdkNDBiMjQ4YWQwMzQ3ZTkxNmRlZmVlMTdiYTUxMTY0MDExIn0=