Skip to content

build: reenable tests #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofisl merged 9 commits into from
Dec 21, 2022
Merged

build: reenable tests #3803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
377b7c3
reenable tests
sofisl Dec 20, 2022
054358c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 20, 2022
1822f8f
Merge branch 'main' into reenableTests
sofisl Dec 20, 2022
b6c1811
Merge branch 'main' into reenableTests
sofisl Dec 20, 2022
19ebbb5
Merge branch 'main' into reenableTests
sofisl Dec 20, 2022
afb976a
Merge branch 'main' into reenableTests
sofisl Dec 20, 2022
6767b6e
Merge branch 'main' into reenableTests
sofisl Dec 21, 2022
aef0bcc
Merge branch 'main' into reenableTests
sofisl Dec 21, 2022
6d5d797
Merge branch 'main' into reenableTests
sofisl Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/google-analytics-admin/samples/test/quickstart.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,9 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

const cwd = path.join(__dirname, '..');

describe.skip('Quickstart', async () => {
describe('Quickstart', async () => {
it('should run quickstart', async () => {
try {
execSync('node quickstart.js', {cwd});
} catch (err) {
// Since we don't have credentials, we need to assert this eror
assert.match(err, /insufficient authentication scopes/);
}
const output = execSync('node quickstart.js', {cwd});
assert(output != null);
});
});
2 changes: 1 addition & 1 deletion packages/google-analytics-data/samples/test/quickstart.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

const GA4_PROPERTY_ID = process.env.GA4_PROPERTY_ID || '222596558';

describe.skip('Quickstart', () => {
describe('Quickstart', () => {
it('should run quickstart', async () => {
// eslint-disable-next-line no-unused-vars
const stdout = execSync(`node ./quickstart.js ${GA4_PROPERTY_ID}`);
Expand Down
2 changes: 1 addition & 1 deletion packages/google-area120-tables/samples/test/quickstart.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const {TablesServiceClient} = require('@google/area120-tables');

const client = new TablesServiceClient();

describe.skip('Quickstart', () => {
describe('Quickstart', () => {
let projectId;

before(async () => {
Expand Down
16 changes: 4 additions & 12 deletions packages/google-iam-credentials/samples/test/quickstart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,9 @@ const cwd = path.join(__dirname, '..');

describe('Quickstart', () => {
it('should run quickstart', async () => {
// We no longer use service account credentials, so we must assert an error
try {
execSync(
'node ./quickstart.js fake_account@long-door-651.iam.gserviceaccount.com https://www.googleapis.com/auth/iam',
{cwd}
);
} catch (err) {
assert.match(
err,
/Gaia id not found for email fake_account@long-door-651.iam.gserviceaccount.com/
);
}
const output = execSync(
'node ./quickstart.js kokoro-system-test@long-door-651.iam.gserviceaccount.com https://www.googleapis.com/auth/iam'
);
assert(output != null);
});
});