Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: EventEmitter Subscription #35

Merged
merged 15 commits into from
Jul 28, 2014
Merged

WIP: EventEmitter Subscription #35

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e0dbd9c
pubsub: Poll message and emit events.
rakyll Jul 24, 2014
673e438
Add TODO.
rakyll Jul 24, 2014
03c84f0
Adding TODO about the immutability of the subscriptions.
rakyll Jul 24, 2014
41fde88
Convert message data to base64 and decode on pull.
rakyll Jul 24, 2014
95802bf
pubsub: Subscriptions are designed to be persistent. Allow to close w…
rakyll Jul 25, 2014
9db344a
pubsub: Subscribe should not involved in persistent subscription crea…
rakyll Jul 25, 2014
7ee2d87
Allow options to be optional.
rakyll Jul 25, 2014
aab8eb9
pubsub: Allow to get a subscription without listening.
rakyll Jul 25, 2014
405cc6b
Merge branch 'master' of github.com:GoogleCloudPlatform/gcloud-nodejs…
rakyll Jul 26, 2014
50328b1
Include regression tests to coverage.
rakyll Jul 26, 2014
cc3c0c1
pubsub: Adding subscription creation.
rakyll Jul 26, 2014
f00eaad
pubsub: Fixing undefined callback.
rakyll Jul 27, 2014
f054959
pubsub: Add regression tests.
rakyll Jul 27, 2014
8429c24
pubsub: Adding regression tests for subscriptions
rakyll Jul 27, 2014
2461ac4
pubsub: Improving test coverage.
rakyll Jul 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TODO.
  • Loading branch information
@rakyll
rakyll committed Jul 24, 2014
commit 673e438123a34cafc2e5a763741fb63d73b6c7c5
1 change: 1 addition & 0 deletions lib/pubsub/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ Subscription.prototype.pull = function(opts, callback) {
returnImmediately: !!opts.returnImmediately
};
this.conn.makeReq('POST', 'subscriptions/pull', null, body, function(err, message) {
// TODO(jbd): Fix API to return a list of messages.
if (err) {
callback(err);
return;
Expand Down