Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 1, 2017

This commit prevents a double leading slash from being included in the uploaded file name when bucket.file() is called with a path starting with a slash. Only a single slash is removed, because it is assumed that if multiple leading slashes are provided, then the user may have done so on purpose.

Fixes: #1972

This commit prevents a double leading slash from being included
in the uploaded file name when bucket.file() is called with a
path starting with a slash. Only a single slash is removed,
because it is assumed that if multiple leading slashes are provided,
then the user may have done so on purpose.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 1, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented May 1, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ab7b967 on cjihrig:slash into a0341b2 on GoogleCloudPlatform:master.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 1, 2017
@stephenplusplus
Copy link
Contributor

Thank you @cjihrig! I made a small commit with a style change. If that doesn't break, I will merge straight away.

@stephenplusplus stephenplusplus added api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a77e07e on cjihrig:slash into a0341b2 on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants