Skip to content

pubsub: borrow request config from GAX #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 3 commits into from
Apr 21, 2017
Merged

pubsub: borrow request config from GAX #2242

stephenplusplus merged 3 commits into from
Apr 21, 2017

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Apr 20, 2017 •
edited
Loading

We struggled to figure out the right timeout value for topic.publish() (start here), then realized GAX has a big config file with their defaults. Instead of one-by-one implementing a best-guess for a default timeout value, this applies the GAX defaults to all of our API methods.

To Dos

  • Unit tests

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2017
@stephenplusplus stephenplusplus added api: pubsub Issues related to the Pub/Sub API. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 20, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2017
@coveralls
Copy link

coveralls commented Apr 20, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2512d8a on stephenplusplus:spp--pubsub-timeout-from-gax into 19ab795 on GoogleCloudPlatform:master.

@dennismartensson dennismartensson mentioned this pull request Apr 21, 2017
Merged
@stephenplusplus stephenplusplus merged commit a7492c6 into googleapis:master Apr 21, 2017
@mikolajroszak mikolajroszak mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenplusplus @coveralls @googlebot