Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: docs: correct links & add options.pushEndpoint #1745

Merged
merged 2 commits into from
Oct 24, 2016
Merged

pubsub: docs: correct links & add options.pushEndpoint #1745

merged 2 commits into from
Oct 24, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Oct 24, 2016 •
edited
Loading

Fixes #1744
RE: https://github.com/GoogleCloudPlatform/gcloud-common/issues/190

  • corrects all of our dead Pub/Sub links
  • adds a link to the upstream docs for the options argument to Topic#subscribe()
  • introduces options.pushEndpoint shortcut for Topic#subscribe() and PubSub#subscribe()

@stephenplusplus stephenplusplus added docs api: pubsub Issues related to the Pub/Sub API. labels Oct 24, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2016
@stephenplusplus stephenplusplus changed the title pubsub: docs: correct links pubsub: docs: correct links & add options.pushEndpoint Oct 24, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 086b26d on stephenplusplus:spp--1744 into f8f713a on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 4672126 into googleapis:master Oct 24, 2016
This was referenced Jan 2, 2024
Open
Open
@takeratta takeratta mentioned this pull request Mar 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenplusplus @coveralls @googlebot